crbench//

← all cases

Stripping the trailing slash silently malforms URLs built by the unchanged helper

Tier 1 easy python · cross-file · authored, execution-grounded case

Ground-truth defects

d1 · correctness · medium · config.py:3
The diff makes api_base() strip a trailing slash — a plausible normalization. But the unchanged consumer requests_helper.url_for() concatenates the base directly with the resource name, relying on the base ending in a slash. After stripping, the separator is gone and every built URL is malformed. No exception is raised; the break is only visible through the unchanged consumer requests_helper.py.

The change under review

diff
diff --git a/config.py b/config.py
--- a/config.py
+++ b/config.py
@@ -1,3 +1,3 @@
 def api_base(raw):
-    """Return the configured API base URL."""
-    return raw
+    """Return the configured API base URL, without a trailing slash."""
+    return raw.rstrip("/")

Leaderboard for this case

easy · 9 of 9 bots fully caught it (100% solve rate) · 100% avg coverage.

#BotResultCaughtCoverageFindingsFalse alarms
1 Claude Code (Opus 5.5) solved 1/1 100.0% 2 0
2 Cubic solved 1/1 100.0% 1 0
3 cursor solved 1/1 100.0% 1 0
4 Drape (Deep Review) solved 1/1 100.0% 2 0
5 Drape (Review) solved 1/1 100.0% 1 0
6 greptile solved 1/1 100.0% 1 0
7 Mjolnir (Opus 5.5) solved 1/1 100.0% 2 0
8 Mjolnir (Sonnet 5.5) solved 1/1 100.0% 2 0
9 qodo solved 1/1 100.0% 1 0

Bot results

Claude Code (Opus 5.5) · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
DefectSeverityFoundGrade
d1 medium ✓ off by one
valid · matches d1 · impact medium
valid · impact medium
Before the change, url_for('/', 'users') returned '/users'. Now api_base('/') returns '' so url_for returns 'users', a relative path. The change also breaks every base, because url_for concatenates the resource directly and expects the base to end with a slash. [grounded: diff] [consensus 3/3: valid=3]
raw comments (2)
requests_helper.py:6
`api_base` now removes the trailing slash, but `url_for` still adds the resource straight onto the base and its docstring says the base is expected to end with a slash. Every built URL loses its path separator. For example, `url_for('https://api.example.com/v1/', 'users')` used to return `https://api.example.com/v1/users` and now returns `https://api.example.com/v1users`. That breaks every request built through this helper. Either add the '/' in `url_for` (e.g. `api_base(raw) + '/' + resource.lstrip('/')`) or keep the trailing slash in `api_base`.
config.py:3
`rstrip('/')` turns a base that is just '/' (a root-relative base) into an empty string. URLs built from it become relative paths like 'users' instead of '/users'.
Cubic · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
DefectSeverityFoundGrade
d1 medium ✓ off by one
valid · matches d1 · impact medium
raw comments (2)
config.py:3
<!-- cubic:v=a837b6be-b22b-43f4-bf59-4d809e601bc3 --> <!-- cubic:review-run=914c1278-8430-50bd-ba65-583eba68a3e9 --> <!-- metadata:{"confidence":8} --> P1: Stripping the trailing slash breaks the only caller, `url_for()` in requests_helper.py. It builds `api_base(raw) + resource` and its docstring states "The base URL is expected to end with a slash." After this change, a base of `https://api.example.com/` with resource `users` becomes `https://api.example.comusers` — a malformed URL. Keep the trailing slash, or change `url_for()` to join with `/` explicitly. <details> <summary>Prompt for AI agents</summary> ```text Check if this issue is valid — if so, understand the root cause and fix it. At config.py, line 3: <comment>Stripping the trailing slash breaks the only caller, `url_for()` in requests_helper.py. It builds `api_base(raw) + resource` and its docstring states "The base URL is expected to end with a slash." After this change, a base of `https://api.example.com/` with resource `users` becomes `https://api.example.comusers` — a malformed URL. Keep the trailing slash, or change `url_for()` to join with `/` explicitly.</comment> <file context> @@ -1,3 +1,3 @@ - """Return the configured API base URL.""" - return raw + """Return the configured API base URL, without a trailing slash.""" + return raw.rstrip("/") </file context> ``` </details>
PR-level
<!-- cubic:review-summary:start --> **1 issue found** across 1 file <!-- cubic:review-summary:end --> <details> <summary>Prompt for AI agents (unresolved issues)</summary> ```text Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately. <file name="config.py"> <violation number="1" location="config.py:3"> P1: Stripping the trailing slash breaks the only caller, `url_for()` in requests_helper.py. It builds `api_base(raw) + resource` and its docstring states "The base URL is expected to end with a slash." After this change, a base of `https://api.example.com/` with resource `users` becomes `https://api.example.comusers` — a malformed URL. Keep the trailing slash, or change `url_for()` to join with `/` explicitly.</violation> </file> ``` </details> <sub>Reply with feedback, questions, or to request a fix.<br /><br />[Re-trigger cubic](https://www.cubic.dev/action/re-review/pr/drape-io/crbench-cubic-2026-09/11/ai_pr_review_github_delivery_b24b3951324ce359f3c313a42cc38b93cfc812e16a955a0447192c226dff129e?returnTo=https%3A%2F%2Fgithub.com%2Fdrape-io%2Fcrbench-cubic-2026-09%2Fpull%2F11)</sub> <!-- cubic:review-post:ai_pr_review_github_delivery_b24b3951324ce359f3c313a42cc38b93cfc812e16a955a0447192c226dff129e:37c31f5d397e32af18e843d207c0292062cc6140:914c1278-8430-50bd-ba65-583eba68a3e9 -->
cursor · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
DefectSeverityFoundGrade
d1 medium ✓ off by one
valid · matches d1 · impact medium
raw comments (2)
config.py:3
### Trailing slash strip breaks URL joining **High Severity** <!-- DESCRIPTION START --> `api_base` now strips trailing slashes, but `url_for` still concatenates the base and `resource` with no separator and documents that the base must end with a slash. Built URLs will omit the path delimiter, so API requests go to the wrong path. <!-- DESCRIPTION END --> <!-- BUGBOT_BUG_ID: 58858606-ba15-4e99-9b3f-f5dcf8e46954 --> <!-- LOCATIONS START config.py#L2-L3 LOCATIONS END --> <div><a href="https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9DVVJTT1IiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OmU2MTIwYTk2LTgzYjUtNDM3NS1iNjIyLWU2NmUyMGE4YTEyZSIsImVuY3J5cHRpb25LZXkiOiJtVmVMM0IwLUJRWUlTakhLZ1ltUWNudXJyVjFHMXYwcUNVaWpMOElyNHdrIiwiYnJhbmNoIjoidDEtcHktc3RyaXAtc2xhc2gtYnJlYWtzLXVybCIsInJlcG9Pd25lciI6ImRyYXBlLWlvIiwicmVwb05hbWUiOiJjcmJlbmNoLWN1cnNvci0yMDI2LTA5IiwicHJvdmlkZXIiOiJnaXRodWIifX0" target="_blank" rel="noopener noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/fix-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/fix-in-cursor-light.png"><img alt="Fix in Cursor" width="115" height="28" src="https://cursor.com/assets/images/fix-in-cursor-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/agents?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9XRUIiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OmU2MTIwYTk2LTgzYjUtNDM3NS1iNjIyLWU2NmUyMGE4YTEyZSIsImVuY3J5cHRpb25LZXkiOiJtVmVMM0IwLUJRWUlTakhLZ1ltUWNudXJyVjFHMXYwcUNVaWpMOElyNHdrIiwiYnJhbmNoIjoidDEtcHktc3RyaXAtc2xhc2gtYnJlYWtzLXVybCIsInJlcG9Pd25lciI6ImRyYXBlLWlvIiwicmVwb05hbWUiOiJjcmJlbmNoLWN1cnNvci0yMDI2LTA5IiwicHJOdW1iZXIiOjExLCJjb21taXRTaGEiOiJjMzI4YjVkZmI1OGQxYWNjMTAwOTdkYTYwN2I3ZDg3ZjRlYmY0YTVkIiwicHJvdmlkZXIiOiJnaXRodWIifX0" target="_blank" rel="noopener noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/fix-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/fix-in-web-light.png"><img alt="Fix in Web" width="99" height="28" src="https://cursor.com/assets/images/fix-in-web-dark.png"></picture></a></div> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c328b5dfb58d1acc10097da607b7d87f4ebf4a5d. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>
PR-level
<!-- BUGBOT_REVIEW --> Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue. <!-- BUGBOT_FIX_ALL --> <a href="https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9BTExfSU5fQ1VSU09SIiwiZGF0YSI6eyJyZWRpc0tleSI6ImJ1Z2JvdC1tdWx0aTo5NDM0ZDIzZC02NWFlLTQxYjUtOWJmMC05MWI2N2ZhYTc0ZDQiLCJlbmNyeXB0aW9uS2V5Ijoid3VLY2xKY3ZUQS02ZkVpVkRIS18yeThFTjhQcjVfNDBiOEJ4d3pjR2x6WSIsImJyYW5jaCI6InQxLXB5LXN0cmlwLXNsYXNoLWJyZWFrcy11cmwiLCJyZXBvT3duZXIiOiJkcmFwZS1pbyIsInJlcG9OYW1lIjoiY3JiZW5jaC1jdXJzb3ItMjAyNi0wOSIsInByb3ZpZGVyIjoiZ2l0aHViIn19" target="_blank" rel="noopener noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/fix-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/fix-in-cursor-light.png"><img alt="Fix All in Cursor" width="115" height="28" src="https://cursor.com/assets/images/fix-in-cursor-dark.png"></picture></a> <!-- /BUGBOT_FIX_ALL --> <!-- BUGBOT_AUTOFIX_REVIEW_FOOTNOTE_BEGIN --> <sup>❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the [Cursor dashboard](https://www.cursor.com/dashboard/bugbot).</sup> <!-- BUGBOT_AUTOFIX_REVIEW_FOOTNOTE_END --> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c328b5dfb58d1acc10097da607b7d87f4ebf4a5d. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>
Drape (Deep Review) · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
DefectSeverityFoundGrade
d1 medium ✓ off by one
valid · matches d1 · impact medium
valid · impact high
Before the change, api_base("/") returned "/". Now it returns "", so url_for("/", "users") gives "users" where it used to give "/users". The unchanged requests_helper.py docstring says the base "is expected to end with a slash", so the broader break is worse: any base like "https://host/" now produces "https://hostusers". [grounded: diff] [consensus 3/3: valid=3]
raw comments (2)
config.py:3
**Resource URLs lose the slash before the path** `url_for` adds the resource straight onto `api_base(raw)` and relies on the base ending with a slash. Now that `api_base` strips that slash, the base and resource run together. Add the "/" in `url_for` when joining (`api_base(raw) + "/" + resource.lstrip("/")`), or keep the trailing slash. ``` config.py:3 return raw.rstrip("/") requests_helper.py:5 """Build the URL for a resource. The base URL is expected to end with a slash.""" requests_helper.py:6 return api_base(raw) + resource ```
config.py:3
**Root-only base "/" becomes an empty string** `rstrip("/")` removes every trailing slash, so a base of "/" or "https://host//" is collapsed. A base of "/" becomes "", which leaves resource URLs without their leading slash. Strip only one trailing slash, and never strip a base that is just "/". ``` config.py:3 return raw.rstrip("/") ```
Drape (Review) · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
DefectSeverityFoundGrade
d1 medium ✓ off by one
valid · matches d1 · impact medium
raw comments (1)
config.py:3
**Stripping trailing slash breaks URL building** `api_base` now strips the trailing slash, but `url_for` simply concatenates `api_base(raw) + resource` and documents that the base ends with a slash. The base and resource now run together. Keep the slash in api_base, or have url_for join with an explicit '/' (and lstrip the resource). ``` config.py:2 """Return the configured API base URL, without a trailing slash.""" config.py:3 return raw.rstrip("/") requests_helper.py:5 """Build the URL for a resource. The base URL is expected to end with a slash.""" requests_helper.py:6 return api_base(raw) + resource ```
greptile · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
DefectSeverityFoundGrade
d1 medium ✓ off by one
valid · matches d1 · impact medium
raw comments (2)
config.py:3
<a href="#"><img alt="P1" src="https://greptile-static-assets.s3.amazonaws.com/badges/p1.svg?v=9" align="top"></a> **Required URL Separator Removed** When `url_for` receives the documented base form ending in `/` and a relative resource such as `users`, this change removes the only separator before direct concatenation. The result is `https://api.example.comusers` instead of `https://api.example.com/users`. Preserve or reinsert exactly one separator when joining the base and resource. ```suggestion """Return the configured API base URL.""" return raw ```
PR-level
<h3>Greptile Summary</h3> This PR changes API-base normalization to remove trailing slashes. - Updates the `api_base` documentation to describe the normalized result. - Uses `rstrip("/")`, which conflicts with the existing direct URL concatenation contract and can remove the required path separator. <h3>Confidence Score: 4/5</h3> This PR is not safe to merge until URL construction preserves a separator between the normalized base and resource. The documented trailing slash currently supplies the separator used by direct concatenation; removing it causes ordinary relative resources to produce malformed URLs. **Files Needing Attention:** config.py <details><summary><h3>Important Files Changed</h3></summary> | Filename | Overview | |----------|----------| | config.py | Removes trailing slashes from configured API bases, breaking URL construction when resources do not begin with a slash. | </details> <!-- greptile_other_comments_section --> <sub>Reviews (1): Last reviewed commit: ["Update config.py"](https://github.com/drape-io/crbench-greptile-2026-09/commit/4021c5867aa78ac1231c9006f1a5630d6d0724c0) | [Re-trigger Greptile](https://app.greptile.com/api/retrigger?id=64284158)</sub>
Mjolnir (Opus 5.5) · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
DefectSeverityFoundGrade
d1 medium ✓ off by one
valid · impact high
`url_for` adds the resource straight onto `api_base(raw)`, and its docstring says the base is expected to end with a slash. Now that `api_base` strips the trailing slash, a base like `https://api.example.com/v1/` loses its separator, so the resource gets glued onto the path and the URL is malformed. Before this change the same input gave a correct URL. [grounded: diff] [consensus 3/3: valid=3]
valid · matches d1 · impact medium
raw comments (2)
config.py:3
[P1] Removing the trailing slash produces malformed URLs in `url_for` `url_for` in `requests_helper.py:6` builds URLs with `api_base(raw) + resource`, and its docstring says the base URL ends with a slash. With this change the slash is removed, so `url_for("https://api.example.com/v1/", "users")` now returns `https://api.example.com/v1users` where it used to return `https://api.example.com/v1/users`. Every resource URL built from a correctly configured base breaks. Either keep `api_base` returning the slash, or update `url_for` to join the parts with a `/` separator.
config.py:3
[P1] Stripping the trailing slash breaks URL construction in `url_for` `requests_helper.url_for` builds URLs as `api_base(raw) + resource`, and its docstring says it expects the base URL to end with a slash. Now that `api_base` strips trailing slashes, every resource URL loses its separator. For example, `url_for("https://api.example.com/v1/", "users")` used to return `https://api.example.com/v1/users` and now returns `https://api.example.com/v1users`. Every request built through `url_for` will hit the wrong path unless the caller is updated to add the `/` separator itself.
Mjolnir (Sonnet 5.5) · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
DefectSeverityFoundGrade
d1 medium ✓ off by one
valid · matches d1 · impact medium
valid · impact high
The change strips the trailing slash. url_for in the unchanged requests_helper.py builds the URL with `api_base(raw) + resource` and its docstring expects the base to end with a slash, so slash-terminated bases now produce malformed URLs. [grounded: diff] [consensus 3/3: valid=3]
raw comments (2)
config.py:3
[P1] Stripping trailing slash breaks url_for concatenation `api_base` now returns `raw.rstrip("/")`, but the only caller, `url_for` in requests_helper.py:6, builds the URL with `api_base(raw) + resource`. Its docstring says the base URL is expected to end with a slash. For a base like `https://api.example.com/v1/` and resource `users`, the result used to be `https://api.example.com/v1/users`. It is now `https://api.example.com/v1users`, so every URL built through `url_for` is wrong. This happens whenever the configured base has a trailing slash and the resource has no leading slash. The change needs to be paired with a join that adds the separator, or the strip should be dropped.
config.py:3
[P1] Stripping trailing slash breaks URL construction in url_for `api_base` now returns `raw.rstrip("/")`. Its only caller, `url_for` in `requests_helper.py`, builds the URL with `api_base(raw) + resource`, and its docstring says the base is expected to end with a slash. With the usual input `raw="https://api.example.com/v1/"` and `resource="users"`, the result changes from `https://api.example.com/v1/users` to `https://api.example.com/v1users`. That is a wrong URL, and it affects every call that passes a slash-terminated base. Either `url_for` has to add the separator itself, or `api_base` should not strip the slash.
qodo · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
DefectSeverityFoundGrade
d1 medium ✓ off by one
valid · matches d1 · impact medium
raw comments (3)
config.py:3
<img src="https://img.shields.io/badge/High-634FD1?style=flat-square" height="20px" alt="Action required"> 1\. Resource urls lose their path separator <code>🐞 Bug</code> <code>≡ Correctness</code> <pre> <b><i>api_base</i></b> now removes every trailing slash, while <b><i>url_for</i></b> concatenates the returned base directly with <b><i>resource</i></b>. For bases such as <b><i>https://api.example.com/</i></b> and resources such as <b><i>users</i></b>, the result becomes <b><i>https://api.example.comusers</i></b>, and the helper&#x27;s documented slash contract is violated. </pre> <details> <summary><strong>Agent Prompt</strong></summary> ``` Issue description `api_base` strips the trailing slash from configured URLs, but `requests_helper.url_for` directly concatenates the base and resource and expects the base to end with a slash. This produces malformed URLs whenever the resource does not begin with `/`. Fix Focus Areas - config.py[1-3] - requests_helper.py[4-6] Recommended Fix Keep the trailing slash in `api_base`, or update `url_for` to join the normalized base and resource with exactly one slash. Preserve correct behavior for both slash-terminated and non-slash-terminated configured bases, and add coverage for both forms. ``` <code>ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools</code> </details>
PR-level
<h3>Code Review by Qodo</h3> <code>🐞 Bugs (1)</code> <code>📘 Rule violations (0)</code> <code>📜 Skill insights (0)</code> <img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider"> <br/> <img src="https://img.shields.io/badge/High-634FD1?style=flat-square" height="20px" alt="Action required"> <details> <summary> 1. Resource URLs lose their path separator <code>🐞 Bug</code> <code>≡ Correctness</code></summary> <br/> > <details open> ><summary>Description</summary> ><br/> > ><pre> ><b><i>api_base</i></b> now removes every trailing slash, while <b><i>url_for</i></b> concatenates the returned base directly >with <b><i>resource</i></b>. For bases such as <b><i>https://api.example.com/</i></b> and resources such as <b><i>users</i></b>, the >result becomes <b><i>https://api.example.comusers</i></b>, and the helper&#x27;s documented slash contract is >violated. ></pre> ></details> > <details> ><summary>Code</summary> ><br/> > ><code>[config.py[3]](https://github.com/drape-io/crbench-qodo-2026-09/pull/11/files#diff-117426151e93a626f8b46bfdb3a95b3f4a62e5f4dd6e65975a7c50759bf04482R3-R3)</code> > >```diff >+ return raw.rstrip("/") >``` ></details> > <details> ><summary>Evidence</summary> ><br/> > ><pre> >The changed function now returns <b><i>raw.rstrip(&quot;/&quot;)</i></b>, removing the separator. <b><i>url_for</i></b> immediately >appends <b><i>resource</i></b> with <b><i>api_base(raw) + resource</i></b>, and its docstring explicitly says the base is >expected to end with a slash, proving that the change creates malformed URLs for ordinary resources >without a leading slash. ></pre> > > <code>[config.py[1-3]](https://github.com/drape-io/crbench-qodo-2026-09/blob/1c9458e588b5d9c38a041e0a0218ed5eb9636ed6/config.py/#L1-L3)</code> > <code>[requests_helper.py[4-6]](https://github.com/drape-io/crbench-qodo-2026-09/blob/1c9458e588b5d9c38a041e0a0218ed5eb9636ed6/requests_helper.py/#L4-L6)</code> ></details> > <details> ><summary>Agent prompt</summary> ><br/> > >``` >The issue below was found during a code review. Follow the provided context and guidance below and implement a solution > >Issue description >`api_base` strips the trailing slash from configured URLs, but `requests_helper.url_for` directly concatenates the base and resource and expects the base to end with a slash. This produces malformed URLs whenever the resource does not begin with `/`. > >Fix Focus Areas >- config.py[1-3] >- requests_helper.py[4-6] > >Recommended Fix >Keep the trailing slash in `api_base`, or update `url_for` to join the normalized base and resource with exactly one slash. Preserve correct behavior for both slash-terminated and non-slash-terminated configured bases, and add coverage for both forms. >``` > <code>ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools</code> ></details> <hr/> </details> <img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider"> <!-- qodo-context:start --> <details><summary><strong>Context sources</strong></summary> <div>Review mode: <code>🚀 Fast</code>: This is a small, localized URL-normalization behavior change in a single function, with no indicated security-sensitive or broad impact.</div> <!-- qodo-context:end --> </details> <img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider"> <!-- qodo-daily-tip:start --> <details> <summary><strong>Tip of the day</strong></summary> <br/> <pre>💡 Did you know, you can reply &#x27;qodo&#x27; on any finding to push back, ask questions, or dig deeper</pre> <a href="https://docs.qodo.ai/tips-and-tricks">More tips ↗</a> | <a href="https://app.qodo.ai/configurations?tab=display-preferences">Customize Qodo ↗</a> | <a href="https://docs.qodo.ai">Qodo docs ↗</a> </details> <img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider"> <!-- qodo-daily-tip:end --> <!-- https://github.com/drape-io/crbench-qodo-2026-09/commit/1c9458e588b5d9c38a041e0a0218ed5eb9636ed6 --> <a href="https://www.qodo.ai"><img src="https://www.qodo.ai/wp-content/uploads/2025/03/qodo-logo.svg" width="80" alt="Qodo Logo"></a>
PR-level
<h3>PR Summary by Qodo</h3> Strip trailing slashes from configured API base URLs <code>✨ Enhancement</code> <code>🕐 Less than 5 minutes</code> <img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider"> <details> <summary>AI Description</summary> <dl> <dd> <br/> ><pre> >• Normalize configured API base URLs by removing all trailing slash characters. >• Document the normalized return contract for callers. ></pre> </dd> </dl> </details> <details> <summary>High-Level Assessment</summary> <dl> <dd> <br/> >The following are alternative approaches to this PR: <details> <summary><b>1. Join URL components explicitly</b></summary> <dl> <dd> - ➕ Avoids relying on trailing-slash conventions - ➕ Handles base and resource separators consistently - ➕ Makes the URL construction contract explicit - ➖ Requires changing requests_helper.py - ➖ Needs tests covering slash combinations </dd> </dl> </details> <details> <summary><b>2. Preserve the existing trailing slash</b></summary> <dl> <dd> - ➕ Maintains compatibility with the current URL concatenation logic - ➕ Limits the change to documentation or validation - ➖ Leaves callers responsible for supplying the expected URL format - ➖ May permit accidental duplicate slashes elsewhere </dd> </dl> </details> >**Recommendation:** Do not merge this change in isolation. requests_helper.py currently concatenates api_base(raw) directly with the resource and explicitly expects the base to end in a slash, so stripping it can produce malformed URLs. Prefer explicit URL-component joining and add coverage for bases and resources with and without boundary slashes. </dd> </dl> </details> <details> <summary> Files changed (1) <code> +2 / -2 </code> </summary> <dl> <dd> <br/> <details> <summary>Enhancement (1) <code> +2 / -2 </code></summary> <dl> <dd> <details> <summary>config.py<code>Normalize API base URLs without trailing slashes</code> <code>+2/-2</code></summary> <br/> >Normalize API base URLs without trailing slashes > ><pre> >• Updates api_base to remove all trailing slash characters using rstrip. Revises the docstring to describe the new return contract. ></pre> > ><a href='https://github.com/drape-io/crbench-qodo-2026-09/pull/11/files#diff-117426151e93a626f8b46bfdb3a95b3f4a62e5f4dd6e65975a7c50759bf04482'>config.py</a> </details> </dd> </dl> </details> </dd> </dl> </details>