Asynchronous functions deleteScheduledEmailReminder and deleteScheduledSMSReminder are called without await inside forEach loops. This occurs during booking rescheduling/cancellation, and workflow/workflow step deletion/updates. Consequently, scheduled workflow reminders may not be reliably cancelled, potentially leaving them active.
The new immediateDelete branch of deleteScheduledEmailReminder cancels the scheduled email at SendGrid on the spot, and three new call sites use it (rescheduling in handleNewBooking, workflow and workflow-step deletion in workflows.tsx). Each such cancellation stays pending in SendGrid's scheduled_sends until the email's send time, up to 72h ahead, and SendGrid allows only 100 pending cancellations: the limit this PR's deferred, cron-driven cancellation exists to stay under. Under steady rescheduling the immediate cancellations fill it, after which cancellations are rejected (and only logged), both the immediate ones and the cron's deferred ones, so reminders for rescheduled and cancelled bookings are sent anyway.
The new downsize loop tests `tempfile.size` and passes the same expression as the filesize argument to `Upload.create_for`, but the conversion ends in an image optimizer that atomically replaces the file. After the first pass the open Tempfile descriptor refers to an orphaned inode, so the reported size stops tracking the file on disk: the loop condition is frozen at the post-first-pass value and the upload is then rejected as too large by the validator even though the file has been shrunk well under the limit.
The cacher delegator's `GetList` adds an unconditional `if errors.IsResourceExpired(err) { return c.storage.GetList(...) }` fallback to etcd. When the cache snapshot is nil the cacher returns `ResourceExpired`, so consistent paginated LISTs silently fall back to etcd instead of being served from cache, defeating the feature and adding etcd load. The fix gates that fallback behind the cache-snapshot feature flag.
The rewritten reply builder uses one array for two incompatible purposes: a depth-indexed slot array written by index, and a LIFO stash for RESP3 map keys pushed and popped. When a map key is itself an aggregate, the push lands at the same index the slot write uses and the key's children grow the array, so the following value pops the key's last child instead of the key. The map is returned with a wrong key and no error is raised.
`checklist` is stored as a growing `v.array(...)` on the task document, so its size is bounded by Convex's 1 MB per-document limit rather than by anything in the code: once a task accumulates enough items the patch in `addItem` fails and the task can no longer be written. Every toggle also rewrites the whole array, so write cost grows with the item count, and individual items cannot be indexed or queried. The fix is a separate `checklistItems` table keyed by `taskId`. Stated as the document-size limit rather than as a design preference, because that is the hard ceiling that makes writes fail and is what expectations.md records as the pass condition ("risks hitting the 1MB document size limit").
`toggleItem` declares `index: v.number()`, which accepts any float and NaN, and guards with `if (args.index < 0 || args.index >= checklist.length)`. Both comparisons are false for NaN, and 0.5 sits inside the range, so the guard passes, `checklist[args.index]` is `undefined`, and reading `.completed` off it throws an unhandled TypeError. Reachable from the public mutation API, which is what the validator exists to constrain.
Backup code validation is case-sensitive due to the use of indexOf(). This causes validation to fail if a user enters uppercase hex characters, as backup codes should be case-insensitive for a better user experience.
The diff converts the outer cancellation lookup from `find` to `filter` and loops over every calendar reference, but the recurring branch still resolves a single reference with `references.find((ref) => ref.type.includes('_calendar'))` and iterates only the organizer's credentials. For each remaining occurrence only the first reference is deleted and only with the organizer's credentials, so team members' calendar events survive the cancellation.
The new image-set loader offers a "Pad" resize option whose branch is identical to "Stretch": it calls the same full resize to the target width and height, with no aspect-preserving thumbnail and no border fill. A user who loads a folder of differently sized images and picks "Pad" to keep aspect ratio gets every image whose size differs from the first one non-uniformly squashed, silently corrupting the training data, with nothing reporting that the chosen option behaved the same as "Stretch".
`remove_member` deletes the association with `group.users.delete(user_id)`, which for a has_many-through with no `:dependent` resolves to a raw `delete_all` and never instantiates the join model, so the `counter_cache` on GroupUser never decrements. The sibling add path uses `group.add(user)`, which does instantiate and increments, so `groups.user_count` drifts upward monotonically and is rendered to admins and returned by the group endpoint.
`TestNewClaimInfoFromClaim` and `TestNewClaimInfoFromState` assert with an inverted condition: `if reflect.DeepEqual(result, test.expectedResult) { t.Errorf(...) }`. That reports a failure only when the result MATCHES the expectation, so the tests never validate the constructor and pass vacuously (and `expectedResult` is left nil). The fix inverts the check to `if !reflect.DeepEqual(...)`.
The claimInfo-cache tests seed their "item in cache" fixtures under the key `claimName + namespace`, but the cache itself keys entries on `namespace + "/" + claimName`. The mismatched key means the seeded entry is never found, so the `get`/`delete`/`contains` tests pass vacuously without exercising the real lookup. The fix keys the fixtures on `namespace + "/" + claimName` to match the cache.
In verifySafeHtml the prefix length `start` and suffix length `end` are computed independently with no `start+end <= value.length()` guard, so when the OWASP sanitizer balances mis-nested allowed tags (e.g. `<p><b>x</p>` → `<p><b>x</b></p>`) the overlapping prefix/suffix make `value.substring(start, value.length()-end)` have beginIndex > endIndex, throwing StringIndexOutOfBoundsException exactly on the illegal-HTML case it should report.
ConditionalPasskeysEnabled() called without UserModel parameter
The new source-action code generators emit commands with a hardcoded `nbls.`-prefixed name (e.g. `new Command(..., "nbls.generate.code", ...)`) instead of routing the name through `Utils.encodeCommand(command, client.getNbCodeCapabilities())` the way the sibling generators do. Any LSP client whose capabilities use a different command prefix gets a dead source-action menu. The fix runs the command name through `encodeCommand` so it respects the client's prefix.
The pages template sets `isIsrFallback` for an ungenerated path of a `fallback: true` route and clears it only for bots, minimal mode or an existing cache entry, never for on-demand revalidation. Base-server forced a blocking render when `isOnDemandRevalidate` was set. So `res.revalidate('/posts/new')` for a path not yet generated now returns the build-time fallback shell with its cache control deleted: nothing is stored, yet the response carries `x-nextjs-cache: REVALIDATED`, so the revalidate call reports success without generating the page.
The app-page template adds an early `if (isSSG && prerenderInfo?.fallback === false && !isPrerendered) throw new NoFallbackError()` that runs before draft mode or minimal mode is considered. The base-server check it replaces skipped preview/draft mode and minimal mode, and the sibling pages and app-route templates keep a `!isDraftMode` guard. A draft-mode request for a path of a `dynamicParams = false` app page that was not prerendered now returns 404 instead of rendering on demand, which breaks CMS preview of unpublished pages.
In applyFormulas (pkg/querier/postprocess.go), the new RequestTypeScalar branch calls applySeriesLimit on the result of processScalarFormula, but that result's Value is a *qbtypes.ScalarData while applySeriesLimit type-asserts result.Value.(*qbtypes.TimeSeriesData) and returns the result unchanged when the assertion fails. So for scalar/formula query results the call is effectively dead code: the configured order-by and limit on the formula are silently ignored, and scalar formula results come back unordered with no limit applied.
In VisitComparison's IN-clause branch, `case []any: values = varValues` passes an empty slice straight through when a variable resolves to []any{}. condition_builder.go's FilterOperatorIn handler then builds conditions := []string{} from an empty values, and sb.Or(conditions...) with zero arguments returns an empty string (confirmed in the vendored huandu/go-sqlbuilder@v1.35.0 source: Or returns "" when len(orExpr) == 0 after filtering). The generated WHERE-clause fragment for that condition vanishes rather than encoding "no rows match", so a filter meant to exclude everything silently matches all rows instead.
chSQLQuery.renderVars substitutes variable values into the raw ClickHouse query string via strings.Replace BEFORE parsing that string as a Go text/template (tmpl.Parse(query) / tmpl.Execute). If a variable's own VALUE contains the Go template delimiters {{/}}, the substituted text is then re-interpreted as a live template action in the second stage -- e.g. a variable value of "{{.SIGNOZ_START_TIME}}" gets replaced with the numeric start timestamp rather than being treated as literal text, silently changing the rendered query; a malformed template fragment (e.g. "{{.") causes template.Parse to fail, surfacing as an opaque HTTP 500.
parseFieldKeyRequest renames the field-key search parameter from ?name to ?searchText (r.URL.Query().Get("name") -> r.URL.Query().Get("searchText")). parseFieldValueRequest calls parseFieldKeyRequest internally (now reading ?searchText) and separately reads ?name for a different purpose (keySelector.Name, overriding what the key-request set). Any existing caller using GET /api/v1/fields?name=service_name to filter the field-key list gets back all keys instead of a filtered set -- the ?name parameter is simply ignored for that endpoint, a breaking API change with no version bump.
rewriteExpression replaces all quoted string literals in the HAVING expression with __QUOTED_N__ placeholders BEFORE matching column-map keys against it. A key like countIf(level='error') (itself containing a quoted literal) is turned into a regex built from its raw, unprotected form, so it can never match the already-placeholder-substituted expression -- e.g. a HAVING clause countIf(level='error') > 10 reads as countIf(level=__QUOTED_0__) > 10 after quote-protection, and the \bcountIf\(level='error'\) pattern silently fails to match, so the rewrite (and the __result_N substitution downstream code depends on) is silently skipped.