Narrowing a shared visibility gate for one control silently hides two unrelated controls
Tier 1 easy typescript · cross-file · authored, execution-grounded case
Ground-truth defects
The change narrows shouldShowSyncColumns() with `&& conn.supportsColumnSelection`, which is correct for the column-selection control. But the unchanged consumer wizard.ts uses that same gate to show the sync-method and primary-key controls too. For any connector that does not support column selection, those two controls now silently disappear, so the user can no longer choose incremental vs full-refresh sync. The fix is a separate gate for column selection.
The change under review
diff
@@ -2,5 +2,5 @@ import type { Connector } from "./types"; // Whether the table-setup wizard shows the sync columns for a connector. export function shouldShowSyncColumns(conn: Connector): boolean { - return !conn.isDirectQuery; + return !conn.isDirectQuery && conn.supportsColumnSelection; }
Leaderboard for this case
easy · 7 of 9 bots fully caught it (78% solve rate) · 78% avg coverage.
| # | Bot | Result | Caught | Coverage | Findings | False alarms |
|---|---|---|---|---|---|---|
| 1 | Claude Code (Opus 5.5) | solved | 1/1 | 100.0% | 1 | 0 |
| 2 | cursor | solved | 1/1 | 100.0% | 1 | 0 |
| 3 | Drape (Deep Review) | solved | 1/1 | 100.0% | 1 | 0 |
| 4 | Drape (Review) | solved | 1/1 | 100.0% | 1 | 0 |
| 5 | greptile | solved | 1/1 | 100.0% | 1 | 0 |
| 6 | Mjolnir (Opus 5.5) | solved | 1/1 | 100.0% | 2 | 0 |
| 7 | Mjolnir (Sonnet 5.5) | solved | 1/1 | 100.0% | 2 | 0 |
| 8 | Cubic | miss | 0/1 | 0.0% | 0 | 0 |
| 9 | qodo | miss | 0/1 | 0.0% | 0 | 0 |
Bot results
Claude Code (Opus 5.5) · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
| Defect | Severity | Found | Grade |
|---|---|---|---|
| d1 | high | ✓ | exact |
raw comments (1)
This change makes `shouldShowSyncColumns` also require `supportsColumnSelection`, but the gate controls more than column selection. In `wizard.ts:7-9` it decides whether all three controls appear: `sync-method`, `primary-key` and `column-select`. A non-direct-query (synced) connector that doesn't support column selection will now lose the sync-method and primary-key controls as well, so users can't set up how the table syncs. Only `column-select` should depend on `supportsColumnSelection`. Either add a separate gate for column-select, or keep this gate as `!conn.isDirectQuery` and push `column-select` conditionally in `setupControls`.
Cubic · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
| Defect | Severity | Found | Grade |
|---|---|---|---|
| d1 | high | ✗ | — |
raw comments (1)
<!-- cubic:review-summary:start -->
**No issues found** across 1 file
<!-- cubic:review-summary:end -->
<sub>[Re-trigger cubic](https://www.cubic.dev/action/re-review/pr/drape-io/crbench-cubic-2026-09/13/ai_pr_review_github_delivery_5ab51af60d9068bfe6d887e90f6c54f305225975b8767ee5b64554993ae00eaa?returnTo=https%3A%2F%2Fgithub.com%2Fdrape-io%2Fcrbench-cubic-2026-09%2Fpull%2F13)</sub>
<!-- cubic:review-post:ai_pr_review_github_delivery_5ab51af60d9068bfe6d887e90f6c54f305225975b8767ee5b64554993ae00eaa:02e9ee8d16d72482dbd32ddc07fdcc76aff9e7fd:797cca7c-5cd3-5643-b27e-ac3147e620b8 -->
cursor · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
| Defect | Severity | Found | Grade |
|---|---|---|---|
| d1 | high | ✓ | exact |
raw comments (2)
### Gating hides unrelated sync controls
**High Severity**
<!-- DESCRIPTION START -->
`shouldShowSyncColumns` now also requires `supportsColumnSelection`, but `setupControls` uses it to show `sync-method` and `primary-key` as well as `column-select`. Non-direct-query connectors that do not support column selection lose those two controls, so users cannot configure sync method or primary key.
<!-- DESCRIPTION END -->
<!-- BUGBOT_BUG_ID: af2eed8f-39c7-4d79-8d8c-7d770818f49d -->
<!-- LOCATIONS START
gating.ts#L4-L5
LOCATIONS END -->
<div><a href="https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9DVVJTT1IiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OjA1ZjU3OWZhLTUwODctNGE1My1iM2I4LTY5NDlhNGJkNGEyNCIsImVuY3J5cHRpb25LZXkiOiJnNXpwdUl4UEtfdUNSOG5na1FhT3BNeVJDaExkR3g5YjFFY3MyS2pvd2RFIiwiYnJhbmNoIjoidDEtdHMtc2hhcmVkLWdhdGUtaGlkZXMtc3luYy1jb2x1bW5zIiwicmVwb093bmVyIjoiZHJhcGUtaW8iLCJyZXBvTmFtZSI6ImNyYmVuY2gtY3Vyc29yLTIwMjYtMDkiLCJwcm92aWRlciI6ImdpdGh1YiJ9fQ" target="_blank" rel="noopener noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/fix-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/fix-in-cursor-light.png"><img alt="Fix in Cursor" width="115" height="28" src="https://cursor.com/assets/images/fix-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9XRUIiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OjA1ZjU3OWZhLTUwODctNGE1My1iM2I4LTY5NDlhNGJkNGEyNCIsImVuY3J5cHRpb25LZXkiOiJnNXpwdUl4UEtfdUNSOG5na1FhT3BNeVJDaExkR3g5YjFFY3MyS2pvd2RFIiwiYnJhbmNoIjoidDEtdHMtc2hhcmVkLWdhdGUtaGlkZXMtc3luYy1jb2x1bW5zIiwicmVwb093bmVyIjoiZHJhcGUtaW8iLCJyZXBvTmFtZSI6ImNyYmVuY2gtY3Vyc29yLTIwMjYtMDkiLCJwck51bWJlciI6MTMsImNvbW1pdFNoYSI6ImViOTY5N2QwM2U2MjYwZjk2Nzk4OGZiMzYyN2UyY2E2Yzc5MzdjY2YiLCJwcm92aWRlciI6ImdpdGh1YiJ9fQ" target="_blank" rel="noopener noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/fix-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/fix-in-web-light.png"><img alt="Fix in Web" width="99" height="28" src="https://cursor.com/assets/images/fix-in-web-dark.png"></picture></a></div>
<sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit eb9697d03e6260f967988fb3627e2ca6c7937ccf. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- BUGBOT_REVIEW -->
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
<!-- BUGBOT_FIX_ALL -->
<a href="https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9BTExfSU5fQ1VSU09SIiwiZGF0YSI6eyJyZWRpc0tleSI6ImJ1Z2JvdC1tdWx0aTo3MmE3ZmVhMi0xMzQ5LTQzYTAtYjA0Zi0zYjQwOWFmNDlkZDciLCJlbmNyeXB0aW9uS2V5Ijoia2Nnb3RIbjdRVFBQUi16Zl9DdGRjNlQ0UGVQUkFEYXVzQ1k2a2RwVWpqdyIsImJyYW5jaCI6InQxLXRzLXNoYXJlZC1nYXRlLWhpZGVzLXN5bmMtY29sdW1ucyIsInJlcG9Pd25lciI6ImRyYXBlLWlvIiwicmVwb05hbWUiOiJjcmJlbmNoLWN1cnNvci0yMDI2LTA5IiwicHJvdmlkZXIiOiJnaXRodWIifX0" target="_blank" rel="noopener noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/fix-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/fix-in-cursor-light.png"><img alt="Fix All in Cursor" width="115" height="28" src="https://cursor.com/assets/images/fix-in-cursor-dark.png"></picture></a>
<!-- /BUGBOT_FIX_ALL -->
<!-- BUGBOT_AUTOFIX_REVIEW_FOOTNOTE_BEGIN -->
<sup>❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the [Cursor dashboard](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- BUGBOT_AUTOFIX_REVIEW_FOOTNOTE_END -->
<sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit eb9697d03e6260f967988fb3627e2ca6c7937ccf. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>
Drape (Deep Review) · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
| Defect | Severity | Found | Grade |
|---|---|---|---|
| d1 | high | ✓ | exact |
raw comments (1)
**Sync method and primary key wrongly hidden**
This gate covers sync-method and primary-key as well as column-select. So a synced (not direct-query) connector without column selection now loses all three controls, not just column-select. Keep this gate as `!conn.isDirectQuery`. In `setupControls`, add "column-select" only when `conn.supportsColumnSelection` is true.
```
gating.ts:5 return !conn.isDirectQuery && conn.supportsColumnSelection;
wizard.ts:7 if (shouldShowSyncColumns(conn)) {
wizard.ts:8 controls.push("sync-method", "primary-key", "column-select");
types.ts:2 isDirectQuery: boolean;
types.ts:3 supportsColumnSelection: boolean;
```
Drape (Review) · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
| Defect | Severity | Found | Grade |
|---|---|---|---|
| d1 | high | ✓ | exact |
raw comments (1)
**Sync method and primary key controls wrongly hidden**
`shouldShowSyncColumns` now also requires `supportsColumnSelection`, but `setupControls` uses it to gate `sync-method` and `primary-key` as well as `column-select`. Non-direct-query connectors that can't select columns lose the sync controls too. Keep the original gate for sync-method and primary-key. Gate only column-select on supportsColumnSelection, for example with a separate check in wizard.ts.
```
gating.ts:5 return !conn.isDirectQuery && conn.supportsColumnSelection;
wizard.ts:7 if (shouldShowSyncColumns(conn)) {
wizard.ts:8 controls.push("sync-method", "primary-key", "column-select");
```
greptile · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
| Defect | Severity | Found | Grade |
|---|---|---|---|
| d1 | high | ✓ | exact |
raw comments (2)
<a href="#"><img alt="P1" src="https://greptile-static-assets.s3.amazonaws.com/badges/p1.svg?v=9" align="top"></a> `supportsColumnSelection` now controls all three sync settings. A non-direct-query connector with `supportsColumnSelection: false` loses `sync-method` and `primary-key` along with `column-select`. Keep the non-direct-query gate for the first two controls, and apply `supportsColumnSelection` only to `column-select`.
<h3>Greptile Summary</h3>
The table-setup wizard now shows sync controls only when a connector supports column selection and is not direct query.
- Adds column-selection support to the existing sync-control gate.
<h3>Confidence Score: 4/5</h3>
This PR is not safe to merge because it hides needed sync settings when a connector only lacks column selection.
`setupControls` puts three controls behind `shouldShowSyncColumns`. The new condition removes all three when `supportsColumnSelection` is false.
**Files Needing Attention:** `gating.ts` needs a narrower gate.
<details><summary><h3>Important Files Changed</h3></summary>
| Filename | Overview |
|----------|----------|
| gating.ts | `shouldShowSyncColumns` now checks `supportsColumnSelection`. Its caller uses the result for three controls, so connectors that cannot choose columns also lose `sync-method` and `primary-key`. |
</details>
<details open><summary><h3>Sequence Diagram</h3></summary>
```mermaid
sequenceDiagram
actor User
participant Wizard as setupControls
participant Gate as shouldShowSyncColumns
User->>Wizard: Open table setup with connector
Wizard->>Gate: Check connector
alt Direct query or column selection unsupported
Gate-->>Wizard: false
Wizard-->>User: Show table-name only
else Non-direct query and column selection supported
Gate-->>Wizard: true
Wizard-->>User: Show table-name, sync-method, primary-key, column-select
end
```
</details>
<!-- greptile_other_comments_section -->
<sub>Reviews (1): Last reviewed commit: ["Update gating.ts"](https://github.com/drape-io/crbench-greptile-2026-09/commit/7af111048b2e0e3d150bee4c459d0103d6d6e32a) | [Re-trigger Greptile](https://app.greptile.com/api/retrigger?id=64284176)</sub>
Mjolnir (Opus 5.5) · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
| Defect | Severity | Found | Grade |
|---|---|---|---|
| d1 | high | ✓ | exact |
wizard.ts uses this one gate for sync-method, primary-key and column-select. Adding supportsColumnSelection to it means a syncing connector without column selection loses all three controls, not just column-select. [grounded: diff] [consensus 3/3: valid=3]
raw comments (2)
[P1] Column-selection check hides sync-method and primary-key too
`shouldShowSyncColumns` is the only gate in `wizard.ts` for the whole group of `"sync-method"`, `"primary-key"` and `"column-select"`. Adding `&& conn.supportsColumnSelection` here means a non-direct-query connector with `supportsColumnSelection: false` now loses the sync-method and primary-key controls, not just column selection. Users of those connectors can no longer pick a sync method or primary key during table setup, even though neither setting depends on column selection. The column-selection check should apply only to the `"column-select"` control, for example as a separate check in `setupControls`, and the shared gate should keep its old behavior.
[P1] Column-selection check now hides sync method and primary key too
`shouldShowSyncColumns` is the single gate that `setupControls` in wizard.ts uses for all three controls: `sync-method`, `primary-key` and `column-select`. Adding `&& conn.supportsColumnSelection` to it means any non-direct-query connector that can't do column selection loses all three. Those connectors still sync, so users can no longer pick a sync method or primary key for them in the table-setup wizard. Only `column-select` should depend on `supportsColumnSelection`. That check belongs on the `column-select` push in wizard.ts, or in its own gate, not in this shared one.
Mjolnir (Sonnet 5.5) · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
| Defect | Severity | Found | Grade |
|---|---|---|---|
| d1 | high | ✓ | exact |
In wizard.ts, shouldShowSyncColumns is the only gate for pushing "sync-method", "primary-key" and "column-select". The added supportsColumnSelection condition therefore also hides sync-method and primary-key for non-direct-query connectors that don't support column selection. [grounded: diff] [consensus 3/3: valid=3]
raw comments (2)
[P1] Column-selection check hides unrelated sync controls
`shouldShowSyncColumns` is the only gate for the whole group `"sync-method"`, `"primary-key"` and `"column-select"` in `setupControls` (wizard.ts:7-8). Adding `&& conn.supportsColumnSelection` now hides `sync-method` and `primary-key` for any non-direct-query connector that has `supportsColumnSelection === false`. Those connectors still sync, so users can no longer configure the sync method or primary key, even though only `column-select` depends on column-selection support. The new condition should gate only `column-select`, for example through a separate predicate. It should not go in the shared gate.
[P1] Column-selection check hides sync-method and primary-key controls
The gate `shouldShowSyncColumns` is used in `wizard.ts` (`setupControls`) to decide whether to show `sync-method`, `primary-key` and `column-select` together. Adding `&& conn.supportsColumnSelection` makes the gate false for any non-direct-query connector that doesn't support column selection. Those connectors now lose `sync-method` and `primary-key`, which have nothing to do with column selection, so users can't configure sync for them. Only `column-select` should depend on `supportsColumnSelection`, so that check belongs in its own condition in `wizard.ts`, not in this shared gate.
qodo · cross-file engine perris 0.11.1+proven.tiered0.25.call.read.subclass.type
| Defect | Severity | Found | Grade |
|---|---|---|---|
| d1 | high | ✗ | — |
raw comments (2)
<h3>Code Review by Qodo</h3>
<code>🐞 Bugs (0)</code> <code>📘 Rule violations (0)</code> <code>📎 Requirement gaps (0)</code>
<img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider">
<img src="https://www.qodo.ai/wp-content/uploads/2025/06/qodo-anteater.svg" width="20%">
<h3>Great, no issues found!</h3>
Qodo reviewed your code and found no material issues that require review
<img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider">
<!-- qodo-daily-tip:start -->
<details>
<summary><strong>Tip of the day</strong></summary>
<br/>
<pre>💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper</pre>
<a href="https://docs.qodo.ai/tips-and-tricks">More tips ↗</a> | <a href="https://app.qodo.ai/configurations?tab=display-preferences">Customize Qodo ↗</a> | <a href="https://docs.qodo.ai">Qodo docs ↗</a>
</details>
<img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider">
<!-- qodo-daily-tip:end -->
<!-- https://github.com/drape-io/crbench-qodo-2026-09/commit/621ba915135331ecf9a538d48607820ff3349d1e -->
<a href="https://www.qodo.ai"><img src="https://www.qodo.ai/wp-content/uploads/2025/03/qodo-logo.svg" width="80" alt="Qodo Logo"></a>
<h3>PR Summary by Qodo</h3>
Hide sync columns for unsupported connectors
<code>🐞 Bug fix</code> <code>🕐 Less than 5 minutes</code>
<img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider">
<details>
<summary>AI Description</summary>
<dl>
<dd>
<br/>
><pre>
>• Hide sync-column controls when connectors do not support column selection.
>• Preserve existing exclusion for direct-query connectors.
></pre>
</dd>
</dl>
</details>
<details>
<summary>Diagram</summary>
<dl>
<dd>
<br/>
```mermaid
graph TD
A["Connector flags"] --> B{"Eligible connector?"} -->|Yes| C["Sync controls"]
B -->|No| D["Controls hidden"]
```
</dd>
</dl>
</details>
<details>
<summary>High-Level Assessment</summary>
<dl>
<dd>
<br/>
>The combined predicate is the simplest fit for the existing shared gate and connector capability model. Splitting the wizard controls into separate gates would add complexity without evidence that unsupported connectors should retain the other sync controls.
</dd>
</dl>
</details>
<details>
<summary> Files changed (1) <code> +1 / -1 </code> </summary>
<dl>
<dd>
<br/>
<details>
<summary>Bug fix (1) <code> +1 / -1 </code></summary>
<dl>
<dd>
<details>
<summary>gating.ts<code>Require column-selection support for sync controls</code> <code>+1/-1</code></summary>
<br/>
>Require column-selection support for sync controls
>
><pre>
>• Extends the sync-column visibility predicate to reject connectors without column-selection support. Direct-query connectors remain excluded as before.
></pre>
>
><a href='https://github.com/drape-io/crbench-qodo-2026-09/pull/13/files#diff-3fe5394283fd230c8589dce4dba2367c40e12cc4af892120e2dc7d7951bec536'>gating.ts</a>
</details>
</dd>
</dl>
</details>
</dd>
</dl>
</details>